Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix required engine for app #6810

Merged
merged 2 commits into from
May 17, 2019
Merged

fix required engine for app #6810

merged 2 commits into from
May 17, 2019

Conversation

elevatebart
Copy link
Contributor

When running yarn bootstrap on a node 10 engine, I get the following error

TSFILE: /Users/ledouxb/Documents/github/storybook/lib/ui/dist/keyboard/platform.d.ts
TSFILE: /Users/ledouxb/Documents/github/storybook/lib/ui/dist/keyboard/keyCodes.d.ts
TSFILE: /Users/ledouxb/Documents/github/storybook/lib/ui/dist/keyboard/keyModel.d.ts
TSFILE: /Users/ledouxb/Documents/github/storybook/lib/ui/dist/keyboard/scanCode.d.ts
Built: @storybook/[email protected]
lerna ERR! yarn run prepare exited 1 in '@storybook/react-native'
lerna ERR! yarn run prepare stdout:
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

lerna ERR! yarn run prepare stderr:
error @storybook/[email protected]: The engine "node" is incompatible with this module. Expected version "^8". Got "10.14.2"
error Commands cannot run with an incompatible environment.

lerna ERR! yarn run prepare exited 1 in '@storybook/react-native'
lerna WARN complete Waiting for 3 child processes to exit. CTRL-C to exit immediately.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

according to this doc, engines should be specified in a different way than dependencies.

this fixes yarn bootstrap

@vercel
Copy link

vercel bot commented May 17, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-fix-nodeengine.storybook.now.sh

@ndelangen ndelangen added the bug label May 17, 2019
@elevatebart
Copy link
Contributor Author

@ndelangen this is what we just talked about ;)

@ndelangen ndelangen merged commit 20dd1ec into next May 17, 2019
@ndelangen ndelangen deleted the fix-nodeengine branch May 17, 2019 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

@alterx alterx Awaiting requested review from alterx

@danielduan danielduan Awaiting requested review from danielduan

@Gongreg Gongreg Awaiting requested review from Gongreg

@igor-dv igor-dv Awaiting requested review from igor-dv

@kazupon kazupon Awaiting requested review from kazupon

@leonrodenburg leonrodenburg Awaiting requested review from leonrodenburg

@naipath naipath Awaiting requested review from naipath

@rmevans9 rmevans9 Awaiting requested review from rmevans9

@shilman shilman Awaiting requested review from shilman

@thomasbertet thomasbertet Awaiting requested review from thomasbertet

@tmeasday tmeasday Awaiting requested review from tmeasday

Assignees

@elevatebart elevatebart

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elevatebart @ndelangen